Conversation
timlichtenberg
requested changes
Mar 25, 2026
Member
timlichtenberg
left a comment
timlichtenberg
left a comment
There was a problem hiding this comment.
Two bugs to fix, otherwise looks good.
Also: l_cocs -> l_ocs rename in def_control.F90 is a good fix but unrelated to the gas list expansion, worth noting in the PR description. And make/Mk_cmd only changed the date stamp, could be left out of the diff.
Member
Author
|
Thanks for catching these. I've removed the duplicated lines and updated the PR on the MetOffice repo. |
timlichtenberg
approved these changes
Mar 25, 2026
Member
Author
|
Thank you! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a duplicate of the pull request on the MetOffice repo: MetOffice#27
However, it would be ideal to merge these changes into our fork ASAP, so we can work on developing new spectral files. It will also prevent us being bottlenecked by their PR review process.